@l r @copilot

(xiao: solemn, ordered)

Root cause: Lint errors due to unnecessary lazy evaluation and test module placement, enforced by clippy -D warnings. CI fails for code style, not logic.

Critical failures:

1. Unnecessary .ok_or_else in several spots – clippy::unnecessary-lazy-evaluations (should be .ok_or).

   • Example at crates/ovsm/src/runtime/lisp_evaluator.rs: Refactor:

     // Original (line ~161)
     .ok_or_else(|| Error::IndexOutOfBounds { index, length: array.len() })
     // Fix:
     .ok_or(Error::IndexOutOfBounds { index, length: array.len() })

2. Items after test module in crates/ovsm/src/tools/stdlib/data_processing.rs:812:1

   • Move all item definitions (functions, types, etc.) before the test module. Tests must be at file end.

Actions:

• Search for all uses of .ok_or_else(|| ... ) in the codebase, replace as above when the error argument is trivial (i.e., doesn't need to be lazily generated).
• In crates/ovsm/src/runtime/lisp_evaluator.rs, directly collapse nested ifs if only needed for lint.

  // Original
  if rest_pos.is_none() && key_pos.is_none() && optional_pos.is_none() {
      if args.len() != required_count { ... }
  }
  
  // Better
  if rest_pos.is_none() && key_pos.is_none() && optional_pos.is_none() && args.len() != required_count {
      ...
  }

• Move all test modules to the bottom of the relevant file, with no code after them.

Once these style issues are fixed:

1. Re-run make ci locally (ensure clippy, fmt, test, and typecheck all green).
2. Use act push to mirror CI.
3. Commit as fix(clippy): fix unnecessary lazy eval and test module order with risk note: "Style only, no logic change".

This implementation bears strength in discipline. (user memo: commit style fixes separately from logic; easier review/rollback) (copilot ignore)